[Webkit-unassigned] [Bug 139173] DOMError should be constructible as per the DOM4 specification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139173

--- Comment #11 from Shivakumar J M <shiva.jm at samsung.com> ---
(In reply to comment #8)
> Comment on attachment 242387 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=242387&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        I have confirmed this indeed matches the behavior of Chrome.
> 
> According to https://src.chromium.org/viewvc/blink?view=rev&revision=172718,
> this also matches Firefox (tested 28). BTW, not the first time I wonder but
> are you porting patches over from Blink? If so, please point to the Blink
> commit in your Changelog.
> 
> > Source/WebCore/dom/DOMError.h:53
> >      explicit DOMError(const String& name);
> 
> We can probably get rid of this constructor and add a default value to the
> second argument below.
> 
> > Source/WebCore/dom/DOMError.h:54
> > +    DOMError(const String& name, const String& message);
> 
> explicit if you mark the second argument as optional.


Dear Chris,

     Thanks for the inputs, updated the patch with comments and also added Blink commit id in the change log. I did not know the procedure to get exact Blink commit revision link. But Usually we read the latest/draft specs and compare the current webkit implementation suppourt, if webkit does not match to latest spec then test with other browser by writing simple manual test, if other browsers suppourts the feature then learn from the other browser, if they already suppourt. I will try to mention the exact change id of patches for future patches, if its learnt/port/inspired from other browser suppourt.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141209/1024287d/attachment-0002.html>