[Webkit-unassigned] [Bug 139423] Copy and Lookup menu items should be disabled when something is not copyable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139423

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242864|review?                     |review+
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 242864
  --> https://bugs.webkit.org/attachment.cgi?id=242864
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242864&action=review

> Source/WebCore/rendering/HitTestResult.cpp:549
> +    Node* node = innerNode();

It seems like we need to run over all of the nodes in the range that we expand out to, not just the HitTestResult's innerNode (for user-select: none).

> Source/WebKit2/UIProcess/mac/WKActionMenuController.mm:783
> +    if (!hitTestResult->allowsCopy()) {

You can move this into the thing that makes them.

> Source/WebKit/mac/WebView/WebActionMenuController.mm:481
> +    if (!_hitTestResult.allowsCopy()) {

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141209/6a536ddc/attachment-0002.html>