[Webkit-unassigned] [Bug 139384] Fix Build Warning in JavaScriptCore ControlFlowProfiler::dumpData() api

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139384

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242787|review?                     |review-
              Flags|                            |

--- Comment #8 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 242787
  --> https://bugs.webkit.org/attachment.cgi?id=242787
Patch-Updated-Review1

View in context: https://bugs.webkit.org/attachment.cgi?id=242787&action=review

> Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58
> +        dataLog("SourceID: %ld\n", iter->key);

This is wrong.  dataLog() doesn’t take a format string.  Instead, it should take a comma separated list or items to be printed.  The correct way to do this is:
    dataLog(“SourceID: “, iter->key, “\n”);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141208/fcda7723/attachment-0002.html>