[Webkit-unassigned] [Bug 125775] [GTK] Implement sizes attribute for link tag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 8 07:01:08 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=125775

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 241421 [details]
> > Rebased patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=241421&action=review
> > 
> > > Source/WebCore/bindings/js/JSHTMLLinkElementCustom.cpp:-43
> > > -JSValue JSHTMLLinkElement::sizes(ExecState* exec) const
> > > -{
> > > -    return toJS(exec, globalObject(), impl().sizes());
> > > -}
> > > -
> > 
> > Why are you removing the custom getter?
> 
> Because it's not needed. See
> https://bugs.webkit.org/show_bug.cgi?id=37674#c30

Note that I also changed the idl, so that the getter is auto-generated, so it's not that I've removed it, but that now it's auto-generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141208/6615d720/attachment-0002.html>


More information about the webkit-unassigned mailing list