[Webkit-unassigned] [Bug 138832] [GTK] LDFLAGS is ignored when running g-ir-scanner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138832

--- Comment #4 from Alberto Garcia <berto at igalia.com> ---
Comment on attachment 242219
  --> https://bugs.webkit.org/attachment.cgi?id=242219
[GTK] LDFLAGS is ignored when running g-ir-scanner

View in context: https://bugs.webkit.org/attachment.cgi?id=242219&action=review

> Source/WebKit2/PlatformGTK.cmake:757
> +# Add required -L flags from ${CMAKE_SHARED_LINKER_FLAGS} for g-ir-scanner
> +separate_arguments(INTROSPECTION_ADDITIONAL_LINKER_FLAGS
> +    UNIX_COMMAND ${CMAKE_SHARED_LINKER_FLAGS})
> +foreach (linker_flag ${INTROSPECTION_ADDITIONAL_LINKER_FLAGS})
> +    string(REGEX MATCH "-L[^ ]*" linker_flag_matched "${linker_flag}")
> +    string(COMPARE EQUAL "${linker_flag_matched}" "" linker_flag_not_allowed)
> +    if (linker_flag_not_allowed)
> +        list(REMOVE_ITEM INTROSPECTION_ADDITIONAL_LINKER_FLAGS "${linker_flag}")
> +    endif ()
> +endforeach (linker_flag)
> +

Isn't it easier to do this instead?

string(REGEX MATCHALL "-L[^ ]*" INTROSPECTION_ADDITIONAL_LINKER_FLAGS ${CMAKE_SHARED_LINKER_FLAGS})

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141208/1c9e18e3/attachment-0002.html>