[Webkit-unassigned] [Bug 139384] Fix Build Warning in JavaScriptCore ControlFlowProfiler::dumpData() api

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 7 23:01:57 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139384

--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 242785 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=242785&action=review
> > 
> > > Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58
> > > +        dataLogF("SourceID: %d\n", iter->key);
> > 
> > Looks like the EFL port disagrees with this fix.  Out of curiosity, what
> > port are you seeing this build warning on?
> > 
> > FYI, instead, I think the better fix is to do:
> >     dataLog("SourceID: ā€œ, iter->key, ā€œ\nā€);
> 
> 
> Dear Mark,
> 
>      I am using EFL port, in my local build machine i got these error, but i
> am usng g++-4.8, std=c++11, is it some thing do with setup?
> 
> Thanks

Probably something to do with your compiler/toolchain version or perhaps custom compiler flags that you are using (if any).  Anyway, try the dataLog() version I suggested on the EWS bots.  Every port should be happy with that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141208/6b99791b/attachment-0002.html>


More information about the webkit-unassigned mailing list