[Webkit-unassigned] [Bug 139384] Fix Build Warning in JavaScriptCore ControlFlowProfiler::dumpData() api

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 7 22:53:32 PST 2014


https://bugs.webkit.org/show_bug.cgi?id=139384

Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242785|review?                     |review-
              Flags|                            |

--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 242785
  --> https://bugs.webkit.org/attachment.cgi?id=242785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242785&action=review

> Source/JavaScriptCore/runtime/ControlFlowProfiler.cpp:58
> +        dataLogF("SourceID: %d\n", iter->key);

Looks like the EFL port disagrees with this fix.  Out of curiosity, what port are you seeing this build warning on?

FYI, instead, I think the better fix is to do:
    dataLog("SourceID: ā€œ, iter->key, ā€œ\nā€);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141208/3d6a53cc/attachment-0002.html>


More information about the webkit-unassigned mailing list