[Webkit-unassigned] [Bug 139315] [Win] proj files copying over too many resources.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139315

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242667|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 242667
  --> https://bugs.webkit.org/attachment.cgi?id=242667
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242667&action=review

I think this looks good, but I have a couple of suggestions. Could you take a look and tell me if you disagree with them? r=me, but please make the adjustments I suggested.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.proj:88
> +    </CreateItem>

We should also include JSC.exe (32-and-64-bit versions), but only put them in $(AppleInternalBin32) and $(AppleInternalBin64), not the AAS location. This is really useful for people debugging the SDK loads stuff properly.

> Source/WTF/WTF.vcxproj/WTF.proj:82
> +    </CreateItem>

I don't think WTF has any resource files. Does it?

> Source/WebCore/WebCore.vcxproj/WebCore.proj:85
> +    </CreateItem>

I didn't think we had any WebCore.resources files. Do we?

> Source/WebKit/WebKit.vcxproj/WebKit.proj:85
> +    </CreateItem>

There's also WebKit.tlb, which should be added to the $(AppleInternalBin32) and $(AppleInternalBin64) locations so that people could use C# or other newer MS technologies with WebKit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141205/a7bab5bd/attachment-0002.html>