[Webkit-unassigned] [Bug 109332] EXT_sRGB needs implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=109332

--- Comment #18 from Florian Bösch <pyalot at gmail.com> ---
> > > b) The test makes a point that the EXT_SRGB format is not valid for frame
> > > buffer attachments. Checking frame buffer status on a frame buffer with an
> > > attachment that has an internal format of EXT_SRGB is expected to yield an
> > > INCOMPLETE FRAMEBUFFER STATUS.
> > > I've made this work appropriately, however, I cannot find in the specs
> > > anywhere why this has to be the case...
> > 
> > This is also incorrect. Attaching an sRGB format to a framebuffer is a valid
> > and important use-case for sRGB.
> Looking at the test:
> function runFramebufferTextureConversionTest(format) {
>   var formatString;
>   var validFormat;
>   switch (format) {
>     case ext.SRGB_EXT: formatString = "sRGB"; validFormat = false; break;
>     case ext.SRGB_ALPHA_EXT: formatString = "sRGB_ALPHA"; validFormat =
> true; break;
>     default: return null;
>   }
> 
> And then later,
> if (validFormat)
> ...
> else
> shouldBe("gl.checkFramebufferStatus(gl.FRAMEBUFFER)",
> "gl.FRAMEBUFFER_INCOMPLETE_ATTACHMENT");
> 
> Is the test wrong?

The 1.0.3 test is correct as per https://www.khronos.org/registry/gles/extensions/EXT/EXT_sRGB.txt, here's how it works.

The only valid format for a renderbuffer to attach to a framebuffer is SRGB8_ALPHA8_EXT, the test reflects that here: https://github.com/KhronosGroup/WebGL/blob/master/conformance-suites/1.0.3/conformance/extensions/ext-sRGB.html#L178

The only valid formats for a texture are SRGB_EXT and SRGB_ALPHA_EXT, the test reflects this here: https://github.com/KhronosGroup/WebGL/blob/master/conformance-suites/1.0.3/conformance/extensions/ext-sRGB.html#L159

Attaching an sRGB texture to a framebuffer is a valid use, but this only applies to SRGB_ALPHA_EXT textures, not for SRGB_EXT textures, the test reflects this here: https://github.com/KhronosGroup/WebGL/blob/master/conformance-suites/1.0.3/conformance/extensions/ext-sRGB.html#L313

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141205/e841529d/attachment-0002.html>