[Webkit-unassigned] [Bug 139241] <input> elements get whitespace action menu instead of editable text menu

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139241

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242539|review?                     |review+
              Flags|                            |

--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 242539
  --> https://bugs.webkit.org/attachment.cgi?id=242539
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242539&action=review

> Source/WebKit2/Shared/WebHitTestResult.h:57
>          bool isTextNode;
> +        bool isOverTextInsideFormControlElement;

I would prefer to see isTextNode and isOverTextInsideFormControlElement combined into a single isText (or maybe isOverText), since that is how it is used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141204/608ba044/attachment-0002.html>