[Webkit-unassigned] [Bug 139173] DOMError should be constructible as per the DOM4 specification

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 2 19:45:33 PST 2014


--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 242387
  --> https://bugs.webkit.org/attachment.cgi?id=242387

View in context: https://bugs.webkit.org/attachment.cgi?id=242387&action=review

> Source/WebCore/ChangeLog:9
> +        I have confirmed this indeed matches the behavior of Chrome.

According to https://src.chromium.org/viewvc/blink?view=rev&revision=172718, this also matches Firefox (tested 28). BTW, not the first time I wonder but are you porting patches over from Blink? If so, please point to the Blink commit in your Changelog.

> Source/WebCore/dom/DOMError.h:53
>      explicit DOMError(const String& name);

We can probably get rid of this constructor and add a default value to the second argument below.

> Source/WebCore/dom/DOMError.h:54
> +    DOMError(const String& name, const String& message);

explicit if you mark the second argument as optional.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141203/ca4b0b4a/attachment-0002.html>

More information about the webkit-unassigned mailing list