[Webkit-unassigned] [Bug 58608] Groove/inset/outset borders show solid if the color is black

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58608

--- Comment #61 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 242342
  --> https://bugs.webkit.org/attachment.cgi?id=242342
Addressing reviewer's comments, updated test baseline.

View in context: https://bugs.webkit.org/attachment.cgi?id=242342&action=review

> Source/WebCore/rendering/RenderObject.cpp:2451
> +    const RGBA32 baseDarkColor = 0xFF202020;
> +    const RGBA32 baseLightColor = 0xFFEBEBEB;

I would still like to see a comment that says "derived empirically" or something.

> Source/WebCore/rendering/RenderObject.cpp:2459
> +        if (differenceSquared(color, Color::black) >
> +            differenceSquared(baseDarkColor, Color::black)) {

Please unwrap.

> Source/WebCore/rendering/RenderObject.cpp:2464
> +        if (differenceSquared(color, Color::white) >
> +            differenceSquared(baseLightColor, Color::white)) {

Please unwrap.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141202/483ab397/attachment-0002.html>