[Webkit-unassigned] [Bug 58608] Groove/inset/outset borders show solid if the color is black

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58608

--- Comment #60 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 242342
  --> https://bugs.webkit.org/attachment.cgi?id=242342
Addressing reviewer's comments, updated test baseline.

View in context: https://bugs.webkit.org/attachment.cgi?id=242342&action=review

> LayoutTests/TestExpectations:143
> +

Unrelated change.

> LayoutTests/fast/borders/mixed-border-style2.html:17
> +  <div class="box"></div>

It is not obvious from this test what the expected output is. How does someone rebaselining know if the pixel result is correct?
Also, could this be made a ref test somehow?

> Source/WebCore/rendering/RenderObject.cpp:2495
> +

Unrelated change.

> Source/WebCore/rendering/RenderObject.h:875
> +    void calculateBorderStyleColor(const EBorderStyle&, const BoxSide&, Color&) const;

Can this be static?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141202/cfd1ddb3/attachment-0002.html>