[Webkit-unassigned] [Bug 139019] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for Pasteboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139019

--- Comment #12 from Darin Adler <darin at apple.com> ---
Comment on attachment 242164
  --> https://bugs.webkit.org/attachment.cgi?id=242164
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242164&action=review

>> Source/WebCore/platform/Pasteboard.h:183
>> +    static std::unique_ptr<Pasteboard> createForDragAndDrop();
> 
> There is a concern we support both public constructor and createFoo() factory function. Some reviewers think this is wrong behavior. So, we need to try to remove createFoo() factory function.

That’s not quite right. We don’t to have create functions that simply wrap std::make_unique and add nothing further. But if the create function adds some additional value, then it’s fine to have it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141202/a3c238ef/attachment-0002.html>