[Webkit-unassigned] [Bug 136903] changing SVG <defs> does not update SVG element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136903

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242353|                            |review-
              Flags|                            |

--- Comment #13 from Dean Jackson <dino at apple.com> ---
Comment on attachment 242353
  --> https://bugs.webkit.org/attachment.cgi?id=242353
[WIP] fix.patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242353&action=review

Very close. Just some merge issues, and minor questions about the test modifications.

> LayoutTests/ChangeLog:13
> +2014-12-01  Sylvain Galineau  <galineau at adobe.com>
> +
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * js/dom/dom-static-property-for-in-iteration-expected.txt:
> +        * platform/mac/svg/in-html/svg-inner-html-expected.png: Added.
> +        * svg/css/svg-attribute-length-parsing-expected.txt:
> +        * svg/in-html/svg-inner-html-expected.txt: Added.
> +        * svg/in-html/svg-inner-html.html: Added.
> +

You need to fill in the OOPS! lines here - at least the description and the bug.

For the s/dom/dom-static-property-for-in-iteration-expected.txt line, you should probably explain why this changed. e.g. You moved innerHTML and outerHTML onto Element.

And I think this line is wrong:

platform/mac/svg/in-html/svg-inner-html-expected.png: Added

Didn't you remove that image now that it is a text test?

> LayoutTests/svg/css/svg-attribute-length-parsing-expected.txt:2
> +Test
>  Test CSS parsing on SVG presentation attributes.

Was this expected to change? I don't see the actual test changing.

> Source/WebCore/ChangeLog:13
> -2014-12-01  Bartlomiej Gajda  <b.gajda at samsung.com>
> +2014-12-01  Sylvain Galineau  <galineau at adobe.com>
>  
> -        [MSE] Fix not always calling mediaPlayer seek.
> -        https://bugs.webkit.org/show_bug.cgi?id=139139
> +        No support for innerHTML on SVGElement
> +        https://bugs.webkit.org/show_bug.cgi?id=136903
>  
> -        Reviewed by Jer Noble.
> +        Reviewed by NOBODY (OOPS!).
>  
> -        Original comment states that media source shall always be notified of seek if it's not closed.
> +        Two parts to this patch:
> +        1. Move innerHTML/outerHTML to Element so SVG elements can inherit them, per https://dvcs.w3.org/hg/innerhtml/raw-file/tip/index.html#innerhtml
> +        2. Make sure fragment insertion is processed relative to the proper node, per http://www.whatwg.org/specs/web-apps/current-work/#adjusted-current-node
>  
> -        No new tests needed.
> +        The latter part was ported over from Blink. 
>  

Something really crazy is going on here. I suggest you revert all your changes to ChangeLog, update, then call prepare-ChangeLog again and add your content back.

> Source/WebCore/ChangeLog:16
> +        * bindings/objc/PublicDOMInterfaces.h: Move innerHTML/outerHTML to Element

Nit: Period at end of sentence.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141202/38eebeda/attachment-0002.html>