[Webkit-unassigned] [Bug 139075] [MSE] Unset timestamps of trackbuffers during Reset Parser State algorithm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139075

Bartlomiej Gajda <b.gajda at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242312|0                           |1
        is obsolete|                            |
 Attachment #242317|                            |review?, commit-queue?
              Flags|                            |

--- Comment #7 from Bartlomiej Gajda <b.gajda at samsung.com> ---
Created attachment 242317
  --> https://bugs.webkit.org/attachment.cgi?id=242317&action=review
Patch with LayoutTest , fixed style

> No need to re-initialize this variable here.

> It would be better if this function came after `sourceUpdated()`.

> This comment should go in the ChangeLog, instead of in the test.

> Since this variable is just subtracting constant values from one another,
> you can just define this up at the top of the file with the other const
> values.

> WebKit style has you invert the "if()" logic, call finishTest(), and return
> early.

> WebKit style also has you remove the braces from single-line if clauses. I
> don't think the comment is necessary.

> No need to specify a width and height here.

Fixed above, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141201/32b339f2/attachment-0002.html>