[Webkit-unassigned] [Bug 139121] text node should not be created, On setting document.title to the empty string

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=139121

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242305|review+, commit-queue+      |review?, commit-queue?
              Flags|                            |

--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 242305
  --> https://bugs.webkit.org/attachment.cgi?id=242305
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242305&action=review

The change looks fine overall.

> Source/WebCore/ChangeLog:9
> +        Also This matches the behavior of both Firefox and Chrome.

I have confimed this indeed matches the behavior of Firefox and Chrome.

> Source/WebCore/html/HTMLTitleElement.cpp:107
>  

Could you fix the "const String &value" -> 'const String& value' in the definition since you are editing this code?

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:2
> +<title>document set title no child</title>

We don't need to set a title here.

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:6
> +

No need for this extra line

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:8
> +    var head = document.documentElement.firstChild;

document.head

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:9
> +    head.removeChild(head.firstChild);

head.firstChild looks fragile. But hopefully you don't need this code anymore if you don't set a <title>

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:10
> +    shouldBeEqualToString("document.title", "");

shouldBeEmptyString()

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:12
> +    shouldBeEqualToString("document.title", "");

shouldBeEmptyString()

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:13
> +    shouldBe("head.lastChild.firstChild", 'null');

head.lastChild looks fragile. Maybe document.getElementsByTagName("title")[0] ?

> LayoutTests/fast/dom/Document/document-set-title-no-child.html:14
> +

No need for this extra line

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20141201/be95c8fe/attachment-0002.html>