[Webkit-unassigned] [Bug 135509] New: WebPageProxy::viewDidEnterWindow and viewDidLeaveWindow not being executed when swapping windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 1 09:37:12 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135509

           Summary: WebPageProxy::viewDidEnterWindow and
                    viewDidLeaveWindow not being executed when swapping
                    windows
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bfulgham at webkit.org
                CC: bfulgham at webkit.org, barraclough at apple.com,
                    thorton at apple.com


While debugging Bug 135493, I found that WebPageProxy::viewDidEnterWindow and WebPageProxy::viewDidLeaveWindow methods were not getting called when moving a WKView from one NSWindow in the UIProcess (e.g., the main application window) to the Fullscreen window (see WKFullScreenWindowController::enterFullScreen).

This seems to be happening because the window view state is coalesced such that the operation of moving from application window to fullscreen window, which should involve (1) leaving the application window, and (2) entering the Fullscreen window, is seen as a no-op by the WebPageProxy::dispatchViewStateChange.

We should probably monitor Window ID so that we can avoid combing the "leave->add" pair into a no-op so that the viewDidLeaveWindow is called on the application window, and viewDidEnterWindow is called on the Fullscreen window (and vice-versa when exiting Fullscreen).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list