[Webkit-unassigned] [Bug 136386] Update webkit dashboard to support performance bots

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 16:19:16 PDT 2014


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #237383|review?                     |review+
               Flag|                            |

--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2014-08-29 16:19:22 PST ---
(From update of attachment 237383)
View in context: https://bugs.webkit.org/attachment.cgi?id=237383&action=review

Overall this looks fine, although it looks like adding the concept of perf bots doesn't quite fit into the assumptions about debug and release builds (based on some of the if statements added).  I don't think that should stop us from landing this change, though.

r=me, but I'd prefer it if someone more familiar with the code looked at it, too.  (I CCed some folks.)

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:54
> +        "EFL Linux 64-bit Release WK2": {platform: Dashboard.Platform.LinuxEFL, tester: true, testCategory: Buildbot.TestCategory.WebKit2},
> +        "EFL Linux 64-bit Release WK2 (Perf)": {platform: Dashboard.Platform.LinuxEFL, tester: true, testCategory: Buildbot.TestCategory.Performance}

These seem unrelated to the patch (although I suppose it's okay to add them now while you're in the neighborhood).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list