[Webkit-unassigned] [Bug 136370] Remove NetworkResourceLoaderClient and subclasses.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 10:00:15 PDT 2014


--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2014-08-29 10:00:20 PST ---
(From update of attachment 237350)
View in context: https://bugs.webkit.org/attachment.cgi?id=237350&action=review

>> Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp:264
>> +    if (isSynchronous()) {
> It's slightly annoying that the unusual code path goes first here and elsewhere.

I agree with if...else cases but here specifically we are doing an early return. I think the favored style is that main body of the function is the common case while early returns are exceptions.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list