[Webkit-unassigned] [Bug 110350] ASSERT(upstreamStart.deprecatedNode()->isDescendantOf(enclosingBlock(upstreamEnd.deprecatedNode()))) in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 29 09:17:32 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=110350





--- Comment #14 from Darin Adler <darin at apple.com>  2014-08-29 09:17:37 PST ---
(From update of attachment 233695)
This patch seems kind of strange. It removes an assertion, without any explanation of why except that Chromium already removed it. We need to explain changes. It’s obvious that removing an assertion will make the crash intentionally caused by the assertion go away. What’s not obvious is whether there is some kind of problem left behind. Some editing export should review this and explain why no assertion is needed here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list