[Webkit-unassigned] [Bug 135752] [GTK] Do not look for child processes in the UI process binary path

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 28 05:41:06 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135752





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-08-28 05:41:12 PST ---
(In reply to comment #2)
> This will mean we need to set WEBKIT_EXEC_PATH for running MiniBrowser directly, right?

Yes, that's what the patch does. And I don't like it, because downstream need to patch it to remove that. I think we could pass DEVELOPER_MODE to the compiler and only set the envs for developer builds

#ifdef DEVELOPER_MODE
     g_setenv("WEBKIT_EXEC_PATH", WEBKIT_EXEC_PATH, FALSE);
     g_setenv("WEBKIT_INJECTED_BUNDLE_PATH", WEBKIT_INJECTED_BUNDLE_PATH, FALSE);
#endif

Or only pass WEBKIT_EXEC_PATH and WEBKIT_INJECTED_BUNDLE_PATH for developer builds and check those directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list