[Webkit-unassigned] [Bug 136339] [GTK] test case filter support in run-gtk-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136339





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-08-28 05:23:17 PST ---
(From update of attachment 237304)
View in context: https://bugs.webkit.org/attachment.cgi?id=237304&action=review

Thanks for working on this, I have few comments/questions.

> Tools/Scripts/run-gtk-tests:325
> +        if self._options.filter and self._options.filter.startswith('/'):
> +            tester_command.extend(['-p', self._options.filter])

So, for glib we only support one test case? What happens if the same test is added and skipped? I guess we should ifgnore skipped tests in this case.

> Tools/Scripts/run-gtk-tests:364
> +        if self._options.filter:
> +            filters = self._options.filter.split(',')
> +            basedir = os.path.basename(os.path.dirname(test_program))
> +            subtests = [ f for f in filters if f.startswith(basedir) ]
> +        if not subtests:
> +            subtests = self._get_tests_from_google_test_suite(test_program)

I wouldn't add the tests if we fail to parse the given test in the filter, if there user gave a bad test or whatever, we should not run any test. So here I would do if self._options.filter: else: subtests = self._get_tests_from_google_test_suite(test_program)

> Tools/Scripts/run-gtk-tests:468
> +    option_parser.add_option('-f', '--filter',
> +                             action='store', type='string', dest='filter', default='',
> +                             help='Execute only the specified test(s) of the suite')

I'm not sure filter is the best name, because skipped tests are also filters, and filter also sounds to me like you might be able to filter out. Maybe -t, --tests? Also the help description says test(s) but it's not clear how to specify more than one test

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.