[Webkit-unassigned] [Bug 136248] [GTK] Add webkit_uri_response_get_http_headers to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136248


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237143|review?                     |review+
               Flag|                            |




--- Comment #7 from Gustavo Noronha (kov) <gns at gnome.org>  2014-08-28 04:44:03 PST ---
(From update of attachment 237143)
View in context: https://bugs.webkit.org/attachment.cgi?id=237143&action=review

LGTM

>>> Source/WebKit2/UIProcess/API/gtk/WebKitURIResponse.cpp:280
>>> +    if (!response->priv->resourceResponse.url().protocolIsInHTTPFamily())
>> 
>> Shouldn't this check be done before the previous one?
> 
> I don't think so, once we have a valid pointer we should return that one, no need to check again it's an HTTP response

The detail Sergio may have missed is that httpHeaders is only there if the resposts was for a protocal in the HTTP family. This check protects against creating httpHeaders in the first place (below).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.