[Webkit-unassigned] [Bug 14568] load event can fire prematurely for frameless documents (affects Acid3?)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14568


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |beidson at apple.com




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2014-08-26 15:03:21 PST ---
Frameless documents can't load subresources, so I think that the comment is incorrect, and the bug is invalid.

What Myles is referring to is that implicitClose() dispatches pending load events on ALL documents, as it calls these static functions:

    ImageLoader::dispatchPendingBeforeLoadEvents();
    ImageLoader::dispatchPendingLoadEvents();
    ImageLoader::dispatchPendingErrorEvents();

    HTMLLinkElement::dispatchPendingLoadEvents();
    HTMLStyleElement::dispatchPendingLoadEvents();

This is outright crazy, and does cause problems due to running JS at inopportune time. I'm not sure whether the frameLoader->checkCompleted() code path has the same problem (i.e. whether it ends up synchronously calling implicitClose() too).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.