[Webkit-unassigned] [Bug 136262] Remove UNUSED_PARAM macros from ServicesOverlayController.mm

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 26 12:10:52 PDT 2014


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #237164|review?                     |review-
               Flag|                            |

--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2014-08-26 12:10:59 PST ---
(From update of attachment 237164)
View in context: https://bugs.webkit.org/attachment.cgi?id=237164&action=review

Please fix the UNUSED_PARAM() statements in ServicesOverlayController::selectionRectsDidChange().  Thanks!

> Source/WebKit2/ChangeLog:3
> +        The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures.

Maybe say:  "causing ASan build failures."

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394
> -#else
> -    UNUSED_PARAM(rects);

This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point:


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list