[Webkit-unassigned] [Bug 136262] Remove UNUSED_PARAM macros from ServicesOverlayController.mm

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136262


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #237163|1                           |0
        is obsolete|                            |




--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>  2014-08-26 12:09:33 PST ---
(From update of attachment 237163)
View in context: https://bugs.webkit.org/attachment.cgi?id=237163&action=review

Please post another patch with the UNUSED_PARAM() statements added, and the tab removed from the ChangeLog.  Otherwise, this looks fine.  :)

> Source/WebKit2/ChangeLog:3
> +        The UNUSED_PARAM macros in ServicesOverlayController.mm are causing ASan failures.

Maybe say:  "causing ASan build failures."

> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-394
> -#else
> -    UNUSED_PARAM(rects);

This one actually needs to add two UNUSED_PARAM() statements for new arguments added to the method at some point:

    UNUSED_PARAM(rects);
    UNUSED_PARAM(gapRects);
    UNUSED_PARAM(isTextOnly);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.