[Webkit-unassigned] [Bug 134186] Make it clear to get m_svgExtensions using svgExtensions()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 22 23:18:51 PDT 2014


--- Comment #11 from Daniel Bates <dbates at webkit.org>  2014-08-22 23:18:56 PST ---
(In reply to comment #10)
> > > Source/WebCore/svg/SVGDocumentExtensions.h:76
> > > -    const HashSet<SVGFontFaceElement*>& svgFontFaceElements() const { return m_svgFontFaceElements; }
> > > +    const HashSet<SVGFontFaceElement*>& svgFontFaceElements() { return m_svgFontFaceElements; }
> > 
> > How did you come to the decision to make this function non-const?
> Actually, that is one of my worries and the part that I'd like to hear your opinion. 
> I changed it to non-const and it's according to change of  'svgExtensions()' but I think it's not good.
> Do I need to keep 'const SVGDocumentExtensions* svgExtensions()' for this part?

I don't know at the moment. I will look through the code shortly. Can you save me some time and elaborate on the callers of svgFontFaceElements()? Regardless, it doesn't seem correct to make svgFontFaceElements() non-const given that it doesn't modify state.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list