[Webkit-unassigned] [Bug 135795] [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 22 04:17:35 PDT 2014


--- Comment #19 from Tanay <tanay.c at samsung.com>  2014-08-22 04:17:41 PST ---
(In reply to comment #18)
> Created an attachment (id=236979)
 --> (https://bugs.webkit.org/attachment.cgi?id=236979&action=review) [details]
> Patch

Incorporated the comments. 

> Tools/MiniBrowser/efl/main.c:1134
> +    char *buf = (char *)malloc(sizeof(char) * (len + 1));
> +    snprintf(buf, len + 1, "%s", (char *)data);
> +    return strdup(buf);

Who release the buf?

>From the EFL Genlist documentation the callback function is to return the text for the list item:

"text_get - This function must return a strdup'()ed string, as the caller will free() it when done."

This will be freed with the call to elm_genlist_clear():

"The application can clear the list with elm_genlist_clear() which deletes all the items in the list." 

I have removed the strdup since we are allocating buf anyway and strdup does the same.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list