[Webkit-unassigned] [Bug 135795] [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135795





--- Comment #17 from Tanay <tanay.c at samsung.com>  2014-08-22 03:10:46 PST ---
(In reply to comment #16)
> (From update of attachment 236868 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236868&action=review
> 
> >> Tools/MiniBrowser/efl/main.c:122
> >> +        Evas_Object *history_list;
> > 
> > Keep the last allocated list.
> 
> ewk_back_forward_list_XXX returns Eina_List and the items of that list are reference counted.
> 
> It's because we should keep those items which webkit allocates internally although back forward list are changed.
> 
> So, I think that we'd better to keep the list (with ref counted items).
> It will be released in history_list_hide().

Thanks, from your explanation it looks like a valid concern.

Since the list is reference counted we will maintain it in the window->history struct and dereference the items it in the history_list_hide() call. I will make the changes and update the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.