[Webkit-unassigned] [Bug 135795] [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135795





--- Comment #15 from Ryuan Choi <ryuan.choi at samsung.com>  2014-08-21 17:19:50 PST ---
(From update of attachment 236868)
View in context: https://bugs.webkit.org/attachment.cgi?id=236868&action=review

> Tools/MiniBrowser/efl/main.c:62
> +static Eina_Bool forward_navigation_enabled = EINA_FALSE;

I still think that we don't need to keep this.

> Tools/MiniBrowser/efl/main.c:122
> +        Evas_Object *history_list;

Keep the last allocated list.

> Tools/MiniBrowser/efl/main.c:410
> +static void 
> +history_list_hide(Browser_Window *window)

How about moving this function to near 1127 line ?

> Tools/MiniBrowser/efl/main.c:416
> +

release last allocated list here like below.

EINA_LIST_FREE(list, data) {
    ewk_object_unref(data);
}

> Tools/MiniBrowser/efl/main.c:981
> +history_list_get(void *user_data)

history_list_get(void *user_data, Eina_Bool forward)

> Tools/MiniBrowser/efl/main.c:1134
> +    char *buf = (char *)malloc(sizeof(char) * (len + 1));
> +    snprintf(buf, len + 1, "%s", (char *)data);
> +    return strdup(buf);

Who release the buf?

> Tools/MiniBrowser/efl/main.c:1147
> +navigation_button_longpress_process(void *user_data)

(void *user_data, Eina_Bool forward)

> Tools/MiniBrowser/efl/main.c:1168
> +    evas_object_ref(window->history.history_list);

It's not what I wanted.
history_list is always valid and no need to increase reference.

> Tools/MiniBrowser/efl/main.c:1188
> +    EINA_LIST_FREE(list, data);

Like I memtioned above, I'd like to move this to history_list_hide()

> Tools/MiniBrowser/efl/main.c:1211
> +    evas_object_unref(window->history.history_list); 

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.