[Webkit-unassigned] [Bug 136103] [Win] Assertion fails when running JSC stress tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136103





--- Comment #11 from Brent Fulgham <bfulgham at webkit.org>  2014-08-20 11:00:50 PST ---
(In reply to comment #7)
> (From update of attachment 236874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review
> 
> >>>> Source/JavaScriptCore/bytecode/CodeOrigin.h:143
> >>>> +    static CodeSpecializationKind specializationKindFor(unsigned kind)
> >>> 
> >>> This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile?
> >> 
> >> There is likely a better way to fix this than to remove the type here.
> > 
> > MSVC was not able to convert from unsigned to the Kind enum type.
> > Maybe replace with a static_cast when calling the function instead?
> 
> I see that we’re now using enum classes everywhere.  How about using “enum class Kind : unsigned”?

Yes. See <https://bugs.webkit.org/show_bug.cgi?id=134252> as well. We've hit this numerous times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.