[Webkit-unassigned] [Bug 136103] [Win] Assertion fails when running JSC stress tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 20 10:28:11 PDT 2014


--- Comment #10 from peavo at outlook.com  2014-08-20 10:28:18 PST ---
(In reply to comment #8)
> (From update of attachment 236874 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236874&action=review
> >>>>> Source/JavaScriptCore/bytecode/CodeOrigin.h:143
> >>>>> +    static CodeSpecializationKind specializationKindFor(unsigned kind)
> >>>> 
> >>>> This change should not be necessary. What happens when you don’t change this? Some kind of failure to compile?
> >>> 
> >>> There is likely a better way to fix this than to remove the type here.
> >> 
> >> MSVC was not able to convert from unsigned to the Kind enum type.
> >> Maybe replace with a static_cast when calling the function instead?
> > 
> > I see that we’re now using enum classes everywhere.  How about using “enum class Kind : unsigned”?
> Yes, we should put the static_cast into the specializationKind() function; note that the two other callers in DFGByteCodeParser.cpp would not require a static_cast. Also seems fine to try Mark’s suggestion of moving to an enum class, but I think that will lead to even more changes and I am not sure it’s worth it.

Ok, thanks, updated patch :)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list