[Webkit-unassigned] [Bug 136096] [EFL][WK2] Layout Test storage/websql/sql-error-codes.html is passed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 20 04:30:56 PDT 2014


Michal Pakula vel Rutka <m.pakula at samsung.com> changed:

           What    |Removed                     |Added
 Attachment #236864|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #5 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2014-08-20 04:31:04 PST ---
(From update of attachment 236864)
View in context: https://bugs.webkit.org/attachment.cgi?id=236864&action=review

I checked on my local machine and the test fails the same as on bot. Anyway we cannot take results from our local machines as a reference point, instead we should rely only on build bot results.

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Gardening does not require review, next time please replace this line with something like: Unreviewed gardening and set only cq? leaving r flag not set.

> LayoutTests/platform/efl/TestExpectations:745
> +webkit.org/b/108355 storage/websql/sql-error-codes.html

Still if test starts to pass you should remove whole entry, not remove the modifier. Now leaving a test name without modifier means the same as [ Skip ].

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list