[Webkit-unassigned] [Bug 136076] Expose injected bundle SPI to get a node's URL element, get the visible selection range of that element, and snapshot that range

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136076


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236824|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #8 from Tim Horton <thorton at apple.com>  2014-08-19 14:17:31 PST ---
(From update of attachment 236824)
View in context: https://bugs.webkit.org/attachment.cgi?id=236824&action=review

> Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:119
> +    float scaleFactor = (options & SnapshotOptionsExcludeDeviceScaleFactor) ? 1 : frame->page()->deviceScaleFactor();

It would be nice if we could share this middle block of code with InjectedBundleNodeHandle (and WebPage, etc.), but I'm not sure where to put it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.