[Webkit-unassigned] [Bug 135965] Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135965





--- Comment #7 from Timothy Hatcher <timothy at apple.com>  2014-08-19 11:20:00 PST ---
(From update of attachment 236678)
View in context: https://bugs.webkit.org/attachment.cgi?id=236678&action=review

> Source/WebInspectorUI/UserInterface/Base/Main.js:871
>  WebInspector._pageHidden = function(event)
>  {
> -    this._updateCookieForInspectorViewState();
> +    // FIXME: pagehide events are not firing at the correct time.
> +    // Ignore the event for now, and instead update view state
> +    // every time the ContentView changes instead of only when we close.
> +    // this._updateCookieForInspectorViewState();
>  }

Unregister the event, remove the function and just file a bug?

> Source/WebInspectorUI/UserInterface/Base/Main.js:926
> +    // FIXME: Selecting a CallFrameTreeElement selects the resource, does the code below work?

Good catch. For the Debugger sidebar panel, which has two content tree outlines, selectedSidebarPanel.contentTreeOutline.processingSelectionChange is the wrong check.

The check should iterate over _visibleContentTreeOutlines and look for processingSelectionChange on any of them.

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:684
> +        if (!this._pendingViewStateCookie) {
> +            if (this._viewStateCookieMatchingRepresentedObject && !Array.isArray(treeElements) && treeElements.representedObject === this._viewStateCookieMatchingRepresentedObject) {
> +                treeElements.revealAndSelect();
> +                delete this._viewStateCookieMatchingRepresentedObject;
> +            }
>              return;
> +        }

We talked about a better fox for this in FrameTreeElement.

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:735
> +            // FIXME: Due to the order of tree elements getting inserted and onpopulate
> +            // getting called on the FrameTreeElement, this tree element could get
> +            // immediately removed and re-inserted. At which point, it will not
> +            // get its selected state restored. This is a workaround for that particular
> +            // chain of events. We should fix this in a cleaner way.
> +            this._viewStateCookieMatchingRepresentedObject = matchedElement.representedObject;

Ditto.

> Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js:741
> +                delete this._viewStateCookieMatchingRepresentedObject;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.