[Webkit-unassigned] [Bug 136076] Expose injected bundle SPI to get a node's URL element, get the visible selection range of that element, and snapshot that range

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 19 11:12:05 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=136076





--- Comment #4 from Peyton Randolph <prandolph at apple.com>  2014-08-19 11:12:13 PST ---
(In reply to comment #2)
> (From update of attachment 236814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236814&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:79
> > +WKBundleNodeHandleRef WKBundleNodeHandleGetURLElementHandle(WKBundleNodeHandleRef elementHandle);
> > +
> 
> What’s this? I think you left it in here by mistake.

You're right. Removed.

> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:36
> > +using namespace WebCore;
> 
> We’ve moved away from using namespace WebCore in WebKit2. Just namespace-qualify what you use below.

Removed.

> 
> > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:136
> > +    PaintBehavior cachedPaintBehavior = frameView->paintBehavior();
> 
> We normally call something like this “oldPaintBehavior” or “savedPaintBehavior”.

Changed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list