[Webkit-unassigned] [Bug 136076] Expose injected bundle SPI to get a node's URL element, get the visible selection range of that element, and snapshot that range

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=136076





--- Comment #2 from mitz at webkit.org <mitz at webkit.org>  2014-08-19 11:08:38 PST ---
(From update of attachment 236814)
View in context: https://bugs.webkit.org/attachment.cgi?id=236814&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:79
> +WKBundleNodeHandleRef WKBundleNodeHandleGetURLElementHandle(WKBundleNodeHandleRef elementHandle);
> +

What’s this? I think you left it in here by mistake.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:36
> +using namespace WebCore;

We’ve moved away from using namespace WebCore in WebKit2. Just namespace-qualify what you use below.

> Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:136
> +    PaintBehavior cachedPaintBehavior = frameView->paintBehavior();

We normally call something like this “oldPaintBehavior” or “savedPaintBehavior”.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.