[Webkit-unassigned] [Bug 31993] http://webkit.org/coding/coding-style.html should mention check-webkit-style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31993


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218051|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2014-08-19 09:22:04 PST ---
(From update of attachment 218051)
View in context: https://bugs.webkit.org/attachment.cgi?id=218051&action=review

> Websites/webkit.org/coding/contributing.html:94
> +<p>Your patch will be automatically checked for style compliance before uploading if you use webkit-patch upload.

This mention of webkit-patch upload here is not formatted the way the other mentions in this document are.

> Websites/webkit.org/coding/contributing.html:95
> +You can do it manually with the check-webkit-style script and will be checked always after uploading by <a href="http://trac.webkit.org/wiki/EWS">EWS</a>.

Grammar mistake here. It says:

    You can do it and will be checked

I would write something more like this:

    You can check style manually by running the Tools/Scripts/check-webkit-style script. Style will also be checked on each patch after it is uploaded by the <a href="http://trac.webkit.org/wiki/EWS">WebKit Early Warning System</a>.

It’s a little strange to have a link to the wiki from this page. Normally we don’t do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.