[Webkit-unassigned] [Bug 135463] Fix unintentional integer overflow before widen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135463





--- Comment #4 from Darin Adler <darin at apple.com>  2014-08-18 13:53:53 PST ---
(From update of attachment 235828)
View in context: https://bugs.webkit.org/attachment.cgi?id=235828&action=review

> Source/WebCore/loader/FTPDirectoryParser.cpp:508
> -              uint64_t size = strtoul(tokens[1], NULL, 10) * 512;
> +              uint64_t size = strtoull(tokens[1], 0, 10) * 512;

The style checker told you to change the NULL to a 0, but really we would like to use nullptr here.

> Source/WebCore/loader/ProgressTracker.cpp:237
> +    estimatedBytesForPendingRequests = static_cast<long long>(progressItemDefaultEstimatedLength) * numPendingOrLoadingRequests;

A better change would be to change type of progressItemDefaultEstimatedLength from int to long long instead of adding the cast here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.