[Webkit-unassigned] [Bug 135795] [EFL][WK2] Minibrowser : Enhance application to be able to support history list navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 18 02:58:49 PDT 2014


https://bugs.webkit.org/show_bug.cgi?id=135795





--- Comment #6 from Tanay <tanay.c at samsung.com>  2014-08-18 02:58:56 PST ---
(In reply to comment #4)
> (From update of attachment 236363 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236363&action=review
> 
> > Tools/MiniBrowser/efl/main.c:1138
> > +on_navigation_button_longpress(void *user_data)
> 
> This is not callback function which is registered by evas_object_event_callback_add. So, how do you think just to use navigaton_button_longpress_process() ?
> 

Yes, you are right. Changed the function name.

> > Tools/MiniBrowser/efl/main.c:1149
> > +        int item_count, x = 0, y = 0, width = 0, height = 0;
> 
> Looks C coding style. MiniBrowser is compiled by C++ compiler.
> 

Fixed.

> > Tools/MiniBrowser/efl/main.c:1163
> > +        for (index = 0; index < item_count; index++) {
> 
> index -> int index ?
> 

index a size_t type variable defined with other local variables at ln 1164.

> > Tools/MiniBrowser/efl/main.c:2154
> > +    Eina_Bool auto_repeat = elm_button_autorepeat_get(window->back_button);
> 
> Could you explain why we need to check if the autorepeat is enabled ? It looks back_button's auto repeat setting is always enabled or disabled.

This was part of the code to check if "repeats" is enabled for the buttons. Refactored to always enable the longpress for back and forward evas buttons

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list