[Webkit-unassigned] [Bug 135769] Implement snapping behavior for iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135769





--- Comment #10 from Tim Horton <thorton at apple.com>  2014-08-14 14:18:06 PST ---
(From update of attachment 236615)
View in context: https://bugs.webkit.org/attachment.cgi?id=236615&action=review

> Source/WebCore/rendering/RenderLayer.cpp:3314
> +    // FIXME: Ensure that offsets are also updated in case of programmatic style changes.

Is there a bugzilla bug for this? If so, put the number here.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:3774
> +            if (layer.horizontalSnapOffsets())

if (auto& offsets = layer.horizontalSnapOffsets())
    scrollingGeometry.horizontalSnapOffsets = offsets;

maybe?

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1304
> +    if (_page->mainFrame() && _page->mainFrame()->page() && _page->mainFrame()->page()->scrollingCoordinatorProxy()) {

All of this incrementally grabbing optional things is an unusual style for us. Usually assignment to a local and then early returning if null is more common, I think.

> Source/WebKit2/UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:41
> +#include <WebCore/AxisScrollSnapOffsets.h>

these should all be #import :| including the ones above :|

> Source/WebKit2/UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:119
> +        float potentialSnapPosition = closestSnapOffsetForMainframeScrolling(WebCore::ScrollEventAxis::Horizontal, targetContentOffset->x, velocity.x);

the f in Mainframe should be capitalized

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.