[Webkit-unassigned] [Bug 135288] [GTK] CMake tries to install JavaScriptCore-3.0.gir outside of install prefix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135288





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-08-14 02:01:13 PST ---
(From update of attachment 235520)
View in context: https://bugs.webkit.org/attachment.cgi?id=235520&action=review

> Source/cmake/FindGObjectIntrospection.cmake:48
> -        _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_GIRDIR "girdir" "--define-variable=prefix=${CMAKE_INSTALL_PREFIX}")
> -        _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_TYPELIBDIR "typelibdir" "--define-variable=prefix=${CMAKE_INSTALL_PREFIX}")
> +        _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_GIRDIR "girdir" "--define-variable=datadir=${DATA_INSTALL_DIR}")
> +        _gir_get_pkgconfig_var(INTROSPECTION_INSTALL_TYPELIBDIR "typelibdir" "--define-variable=libdir=${LIB_INSTALL_DIR}")

This is indeed wrong, we want to install the introspection stuff in the standard location together with the other gir and typelibs. DATA_INSTALL_DIR is also versioned, but gir and typelibs doesn't need to be installe din a versioned directory because their filenames already contain the binary version. But the previous code was not correct in my opinion either. We need to get the introspection tools from the pkg-configl file because they might not  be in the path, we definitely don't want to get the girdir and typelibdir from the pkg-config file, because that would mean that if I'm using gobject-instrospection from my distro, but building in muy jhbuild, we would end up trying to install introspection files to /usr. I guess this bug was about that. In autotools we defined both dirs unconditionally depending on $datadir and $libdir.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.