[Webkit-unassigned] [Bug 21358] DragData should not depend on Clipboard, DocumentFragment, and Document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21358





--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2014-08-14 00:10:20 PST ---
(In reply to comment #4)
> (From update of attachment 236519 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=236519&action=review
> 
> > Source/WebCore/page/gtk/DragControllerGtk.cpp:83
> > +    if (!dragData.platformData()->hasMarkup() || !frame->document())
> 
> Since we are not null-checking the Frame here, can we pass it by reference? Or do we need to null check it?

We can indeed pass it by reference, the caller should ensure a valid a frame is passed, and currently the only caller does it:

    RefPtr<Frame> innerFrame = element->document().frame();
    ASSERT(innerFrame);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.