[Webkit-unassigned] [Bug 135919] Add LayoutUnit argument coders to WebCoreArgumentCoders

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135919


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236576|review?                     |review-
               Flag|                            |




--- Comment #5 from Alexey Proskuryakov <ap at webkit.org>  2014-08-13 22:59:11 PST ---
(From update of attachment 236576)
View in context: https://bugs.webkit.org/attachment.cgi?id=236576&action=review

r- for using int.

> Source/WebKit2/ChangeLog:3
> +        Add LayoutUnit argument coders to WebCoreArgumentCoders

It seems a little bit strange to expose internals of layout machinery even to WebKit, and more so to UI process. Can we use whatever type is exposed in API until we get down to WebCore?

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:343
> +    int decodedRawValue;

IPC always uses fixed size types, like uint64_t, not int.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.