[Webkit-unassigned] [Bug 135768] Implement scroll snapping animations on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135768





--- Comment #9 from Wenson Hsieh <wenson_hsieh at apple.com>  2014-08-13 18:15:25 PST ---
(From update of attachment 236492)
View in context: https://bugs.webkit.org/attachment.cgi?id=236492&action=review

>> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:154
>> +    size_t upperIndex = snapOffsets.size() - 1;
> 
> If you move upperIndex to before the if, then you can use it there.

Good catch, thanks!

>> Source/WebCore/platform/mac/AxisScrollSnapAnimator.mm:79
>> +    return 16.6789 * initialWheelDelta;
> 
> Where does this come from?

Good point -- I'll add this as a named constant and leave a comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.