[Webkit-unassigned] [Bug 133319] [GTK] Adds implementation of subtle crypto digest algorithms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=133319





--- Comment #6 from Eduardo Lima Mitev <elima at igalia.com>  2014-08-12 03:47:52 PST ---
(In reply to comment #5)
> Attachment 236437 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/crypto/gtk/CryptoDigestGtk.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
> Total errors found: 1 in 4 files
> 

This is an unavoidable positive:

#include <gnutls/gnutls.h>
#include <gnutls/crypto.h>

Order is alphabetically wrong, but the order cannot be inverted since crypto.h needs gnutls.h included before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.