[Webkit-unassigned] [Bug 135791] [EFL][WK2] Minibrowser: Enhance the application to use download directory selector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135791


Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #236351|review?                     |review+
               Flag|                            |




--- Comment #2 from Gyuyoung Kim <gyuyoung.kim at webkit.org>  2014-08-11 21:07:41 PST ---
(From update of attachment 236351)
View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review

Looks fine.

> Tools/MiniBrowser/efl/main.c:662
> +    Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/home");

Isn't it better to use /tmp when *home_path* isn't set ?

> Tools/MiniBrowser/efl/main.c:674
> +        eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX");

Can't we change download file name as well ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.