[Webkit-unassigned] [Bug 135820] More adjustments to css width calculations of cue boxes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 11 16:59:39 PDT 2014
https://bugs.webkit.org/show_bug.cgi?id=135820
Brent Fulgham <bfulgham at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #236413|review? |review+, commit-queue-
Flag| |
--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> 2014-08-11 16:59:49 PST ---
(From update of attachment 236413)
View in context: https://bugs.webkit.org/attachment.cgi?id=236413&action=review
r=me, but please address the possible zero-base-font-size issue I mentioned.
> Source/WebCore/html/track/TextTrackCueGeneric.cpp:82
> + double authorFontSize = videoSize.height() * cue->baseFontSizeRelativeToVideoHeight() / 100.0;
Can baseFontSizeRelativeToVideoHeight ever be zero (I think it can be)? If the author could arbitrarily set this to zero, I think we should check and fall back to that minimum (10 pt) value from the CSS.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list