[Webkit-unassigned] [Bug 135268] Compute and store snap point positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=135268





--- Comment #10 from Zalan Bujtas <zalan at apple.com>  2014-08-11 15:47:15 PST ---
(From update of attachment 236405)
View in context: https://bugs.webkit.org/attachment.cgi?id=236405&action=review

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.cpp:43
> +void AxisScrollSnapOffsets::appendChildSnapOffsetsToVector(HTMLElement* parent, ScrollEventAxis axis, Vector<LayoutUnit>& snapOffsetSubsequence)

HTMLElement& ?

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.h:31
> +#include "HTMLElement.h"

class HTMLElement instead?

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.h:47
> +    void updateFromOffsets(LayoutUnit, LayoutUnit, const Vector<LayoutUnit>&, LayoutUnit, bool, LayoutUnit);
> +    LayoutUnit closestSnapPosition(LayoutUnit, float = 0) const;

Could you add the argument names? There's no way to tell what those LayoutUnits are for by looking at the .h file.

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.h:52
> +    Vector<LayoutUnit> offsets;

private? m_offsets?

> Source/WebCore/page/scrolling/AxisScrollSnapOffsets.h:53
> +    bool dirty;

not used.

> Source/WebCore/platform/ScrollableArea.cpp:45
> +#include "Element.h"

HTMLElement.h includes Element.h (indirectly)

> Source/WebCore/platform/ScrollableArea.cpp:59
> +    void* horizontalSnapAxisPointer;
> +    void* verticalSnapAxisPointer;
> +#endif

not used?

> Source/WebCore/platform/ScrollableArea.cpp:207
> +void ScrollableArea::updateSnapAxisFromElementAndStyle(ScrollEventAxis axis, Element* scrollingElement, RenderBox* box, const RenderStyle& style)

Element& RenderBox& ?

> Source/WebCore/platform/ScrollableArea.h:31
> +#include "AxisScrollSnapOffsets.h"

wrong order.

> Source/WebCore/platform/ScrollableArea.h:47
> +class AxisScrollSnapOffsets;

already included.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.